Added some type for the HtmlHelper::Meta method to support OpenGraphProtocol #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why is this necessary? This seem like extra 'stuff' just hanging out in CakePHP to save a bit of work for people doing work with Facebook. Personally I think this falls outside the 80% use case we're aiming for with CakePHP. |
|
I also think it is not necessary. I have my own facebook helper under my facebook plugins and that has its own head(), meta() functions. Why I need those in HTML helper? |
|
I have to agree, this doesn't feel 'core' enough. Thank you for the patch though :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.